Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3660)

Unified Diff: chrome/common/child_process.cc

Issue 155944: Switch the first thread in a child process to be the main thread... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/child_process.cc
===================================================================
--- chrome/common/child_process.cc (revision 21342)
+++ chrome/common/child_process.cc (working copy)
@@ -9,14 +9,14 @@
ChildProcess* ChildProcess::child_process_;
-ChildProcess::ChildProcess(ChildThread* child_thread)
- : child_thread_(child_thread),
- ref_count_(0),
- shutdown_event_(true, false) {
+ChildProcess::ChildProcess()
+ : ref_count_(0),
+ shutdown_event_(true, false),
+ io_thread_("Chrome_ChildIOThread") {
DCHECK(!child_process_);
child_process_ = this;
- if (child_thread_.get()) // null in unittests.
- child_thread_->Run();
+
+ io_thread_.StartWithOptions(base::Thread::Options(MessageLoop::TYPE_IO, 0));
}
ChildProcess::~ChildProcess() {
@@ -28,28 +28,29 @@
// notice shutdown before the render process begins waiting for them to exit.
shutdown_event_.Signal();
- if (child_thread_.get())
- child_thread_->Stop();
+ // Kill the main thread object before nulling child_process_, since
+ // destruction code might depend on it.
+ main_thread_.reset();
child_process_ = NULL;
}
void ChildProcess::AddRefProcess() {
- DCHECK(!child_thread_.get() || // null in unittests.
- MessageLoop::current() == child_thread_->message_loop());
+ DCHECK(!main_thread_.get() || // null in unittests.
+ MessageLoop::current() == main_thread_->message_loop());
ref_count_++;
}
void ChildProcess::ReleaseProcess() {
- DCHECK(!child_thread_.get() || // null in unittests.
- MessageLoop::current() == child_thread_->message_loop());
+ DCHECK(!main_thread_.get() || // null in unittests.
+ MessageLoop::current() == main_thread_->message_loop());
DCHECK(ref_count_);
DCHECK(child_process_);
if (--ref_count_)
return;
- if (child_thread_.get()) // null in unittests.
- child_thread_->OnProcessFinalRelease();
+ if (main_thread_.get()) // null in unittests.
+ main_thread_->OnProcessFinalRelease();
}
base::WaitableEvent* ChildProcess::GetShutDownEvent() {

Powered by Google App Engine
This is Rietveld 408576698