Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1559433002: [Android] Call DevToolsServer.destroy where needed (Closed)

Created:
4 years, 11 months ago by mnaganov (inactive)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Call DevToolsServer.destroy where needed [Aw]DevToolsServer is initialized in AwShellActivity, ChromeApplication, and WebViewChromiumFactoryProvider. Make sure it is destroyed in the first two instances. WebView lacks shutdown path, thus we can't do much there. BUG=368171 Committed: https://crrev.com/e305ad32f496d61cf9b38575e3ba02db882e61c2 Cr-Commit-Position: refs/heads/master@{#367159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mnaganov (inactive)
4 years, 11 months ago (2015-12-30 01:03:41 UTC) #2
gone
lgtm I got a little tripped up in the ChromeApplication bit; thought you were destroying ...
4 years, 11 months ago (2015-12-30 01:09:31 UTC) #3
sgurun-gerrit only
lgtm I thought the previous CL was the last cl of the year :)
4 years, 11 months ago (2015-12-30 03:39:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559433002/1
4 years, 11 months ago (2015-12-30 16:30:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 17:14:48 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 17:15:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e305ad32f496d61cf9b38575e3ba02db882e61c2
Cr-Commit-Position: refs/heads/master@{#367159}

Powered by Google App Engine
This is Rietveld 408576698