Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 1559403003: Add a bench to test SkTileImageFilter. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a bench to test SkTileImageFilter. Tests in three modes: no tiling, 32x32 tiled rendering, and 64x64 tiled rendering. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559403003 Committed: https://skia.googlesource.com/skia/+/3c1468188924ede1e6589cddee84031c16782226

Patch Set 1 #

Patch Set 2 : Move to bench dir; remove useless includes #

Patch Set 3 : Fix copyright #

Patch Set 4 : Remove more useless crud #

Total comments: 2

Patch Set 5 : Added comment #

Patch Set 6 : Win32 fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
A bench/TileImageFilterBench.cpp View 1 2 3 4 5 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Stephen White
Rob: PTAL. Thanks!
4 years, 11 months ago (2016-01-05 20:40:45 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/1559403003/diff/60001/bench/TileImageFilterBench.cpp File bench/TileImageFilterBench.cpp (right): https://codereview.chromium.org/1559403003/diff/60001/bench/TileImageFilterBench.cpp#newcode17 bench/TileImageFilterBench.cpp:17: // This bench is interesting because ... ? ...
4 years, 11 months ago (2016-01-05 20:45:48 UTC) #6
Stephen White
https://codereview.chromium.org/1559403003/diff/60001/bench/TileImageFilterBench.cpp File bench/TileImageFilterBench.cpp (right): https://codereview.chromium.org/1559403003/diff/60001/bench/TileImageFilterBench.cpp#newcode17 bench/TileImageFilterBench.cpp:17: On 2016/01/05 20:45:48, robertphillips wrote: > // This bench ...
4 years, 11 months ago (2016-01-05 20:50:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559403003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559403003/80001
4 years, 11 months ago (2016-01-05 20:51:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/5083) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 11 months ago (2016-01-05 20:53:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559403003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559403003/100001
4 years, 11 months ago (2016-01-05 21:12:06 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 21:27:48 UTC) #17
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/3c1468188924ede1e6589cddee84031c16782226

Powered by Google App Engine
This is Rietveld 408576698