Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1559393002: Also ignore sfntly for Google3/iOS. (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
iroth, dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Also ignore sfntly for Google3/iOS. It's just complicating their build process for now. Will follow up by removing sfntly dependency after this rolls. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1559393002 Committed: https://skia.googlesource.com/skia/+/226aee25f426fa12ad16781257490cfd339fb95b

Patch Set 1 #

Patch Set 2 : its fine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pdf/SkPDFFont.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
mtklein_C
I think any LGTM will do.
4 years, 11 months ago (2016-01-05 18:12:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559393002/20001
4 years, 11 months ago (2016-01-05 18:12:53 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 18:35:52 UTC) #9
dogben
lgtm
4 years, 11 months ago (2016-01-05 18:54:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559393002/20001
4 years, 11 months ago (2016-01-05 18:54:46 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:55:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/226aee25f426fa12ad16781257490cfd339fb95b

Powered by Google App Engine
This is Rietveld 408576698