Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1559323002: [prototype user tracking] Don't skip JSGlobalProxies (Closed)

Created:
4 years, 11 months ago by Jakob Kummerow
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[prototype user tracking] Don't skip JSGlobalProxies For a prototype chain foo -> global_proxy -> global_object, we used to register a dependency from foo -> global_object. This is incorrect when the global_proxy/global_object pairing is modified, e.g. when navigating in iframes. With this patch, we properly register foo -> global_proxy and global_proxy -> global_object dependencies. Additionally, when a prototype's prototype changes from null to something else, this new usage relation must be registered if there are other users further down on the prototype chain that might expect a complete chain of registrations to exist (which was the case before, and must be preserved). BUG=chromium:571517 LOG=n R=verwaest@chromium.org Committed: https://crrev.com/b4583c044412c1487198dd25c81a7c664ac97f23 Cr-Commit-Position: refs/heads/master@{#33119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -21 lines) Patch
M src/factory.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 6 chunks +11 lines, -19 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-571517.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
4 years, 11 months ago (2016-01-05 15:20:21 UTC) #1
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-05 15:51:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559323002/1
4 years, 11 months ago (2016-01-05 15:51:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 16:15:05 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 16:15:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4583c044412c1487198dd25c81a7c664ac97f23
Cr-Commit-Position: refs/heads/master@{#33119}

Powered by Google App Engine
This is Rietveld 408576698