Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/IceTypes.def

Issue 1559243002: Suzero. X8664. NaCl Sandboxing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fixes filetype=asm; addresses comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringX86BaseImpl.h ('k') | tests_lit/assembler/x86/sandboxing.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTypes.def
diff --git a/src/IceTypes.def b/src/IceTypes.def
index ebbaa6baa117e26baae755cb083fcd863ac58484..0d4ec8636491213f3fd5d98fa3b3ec8ddfb9af7c 100644
--- a/src/IceTypes.def
+++ b/src/IceTypes.def
@@ -15,14 +15,18 @@
#define SUBZERO_SRC_ICETYPES_DEF
// Attributes of each target architecture.
-// NOTE on is_elf64 -- At some point NaCl would like to use ELF32 for all ILP32
-// sandboxes, but for now the 64-bit architectures use ELF64:
-// https://code.google.com/p/nativeclient/issues/detail?id=349 TODO: Whoever
-// adds AArch64 will need to set ABI e_flags.
+// NOTES on is_elf64:
+// 1- At some point NaCl would like to use ELF32 for all ILP32 sandboxes, but
+// for now the 64-bit architectures use ELF64:
+// https://code.google.com/p/nativeclient/issues/detail?id=349
+//
+// 2- native code is always emitted as ELF32.
+//
+// TODO(jpp): set ABI e_flags for AArch64.
#define TARGETARCH_TABLE \
/* enum value, printable string, is_elf64, e_machine, e_flags */ \
X(Target_X8632, "x86-32", false, EM_386, 0) \
- X(Target_X8664, "x86-64", false, EM_X86_64, 0) \
+ X(Target_X8664, "x86-64", true, EM_X86_64, 0) \
X(Target_ARM32, "arm32", false, EM_ARM, EF_ARM_EABI_VER5) \
X(Target_ARM64, "arm64", true, EM_AARCH64, 0) \
X(Target_MIPS32,"mips32", false, EM_MIPS, 0) \
« no previous file with comments | « src/IceTargetLoweringX86BaseImpl.h ('k') | tests_lit/assembler/x86/sandboxing.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698