pydir/run-pnacl-sz.py - Issue 1559243002: Suzero. X8664. NaCl Sandboxing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/run-pnacl-sz.py

Issue 1559243002: Suzero. X8664. NaCl Sandboxing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pydir/run-pnacl-sz.py

diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py

index b7434adc25de0c02c4143e390e16d50ded727bf1..3852d2dffc36ac2d84e4f8538c66dba6a406752e 100755

--- a/pydir/run-pnacl-sz.py

+++ b/pydir/run-pnacl-sz.py

@@ -15,6 +15,8 @@ def TargetAssemblerFlags(target, sandboxed):

# TODO(reed kotler). Need to find out exactly we need to

# add here for Mips32.

flags = { 'x8632': ['-triple=%s' % ('i686-nacl' if sandboxed else 'i686')],

+ 'x8664': ['-triple=%s' % (

+ 'x86_64-nacl' if sandboxed else 'x86_64')],

'arm32': ['-triple=%s' % (

'armv7a-nacl' if sandboxed else 'armv7a'),

'-mcpu=cortex-a9', '-mattr=+neon'],

@@ -24,6 +26,7 @@ def TargetAssemblerFlags(target, sandboxed):

def TargetDisassemblerFlags(target):

flags = { 'x8632': ['-Mintel'],

+ 'x8664': ['-Mintel'],

'arm32': [],

'mips32':[] }

return flags[target]

@@ -79,7 +82,7 @@ def main():

choices=['obj', 'asm', 'iasm'],

help='Output file type. Default %(default)s.')

argparser.add_argument('--target', default='x8632', dest='target',

- choices=['x8632','arm32','mips32'],

+ choices=['x8632','x8664','arm32','mips32'],

help='Target architecture. Default %(default)s.')

argparser.add_argument('--echo-cmd', required=False,

action='store_true',