Suzero. X8664. NaCl Sandboxing.

src/IceTypes.def

Index: src/IceTypes.def
diff --git a/src/IceTypes.def b/src/IceTypes.def
index ebbaa6baa117e26baae755cb083fcd863ac58484..172161a2451d2f5880e1676eb98359b539740f33 100644
--- a/src/IceTypes.def
+++ b/src/IceTypes.def
@@ -15,14 +15,18 @@
 #define SUBZERO_SRC_ICETYPES_DEF
 
 // Attributes of each target architecture.
-// NOTE on is_elf64 -- At some point NaCl would like to use ELF32 for all ILP32
-// sandboxes, but for now the 64-bit architectures use ELF64:
-// https://code.google.com/p/nativeclient/issues/detail?id=349 TODO: Whoever
-// adds AArch64 will need to set ABI e_flags.
+// NOTES on is_elf64:
+// 1- At some point NaCl would like to use ELF32 for all ILP32 sandboxes, but
+// for now the 64-bit architectures use ELF64:
+//   https://code.google.com/p/nativeclient/issues/detail?id=349
+//
+// 2- native code is always emitted as ELF32.
+//
+// TODO: Whoever adds AArch64 will need to set ABI e_flags.

[Jim Stichnoth, 2016/01/13 18:28:27]

Since you touched this last :)
Can you add a name to the TODO?

[John, 2016/01/13 20:48:03]

I thought about that, but who's supposed to be the TODO'er? I left a TODO(jpp),
but TODO(???) seems more appropriate.

 #define TARGETARCH_TABLE                                                       \
   /* enum value, printable string, is_elf64,   e_machine, e_flags */           \
   X(Target_X8632, "x86-32", false, EM_386,     0)                              \
-  X(Target_X8664, "x86-64", false, EM_X86_64,  0)                              \
+  X(Target_X8664, "x86-64", true, EM_X86_64,  0)                               \

[Jim Stichnoth, 2016/01/13 18:28:26]

fix beautiful column alignment

[John, 2016/01/13 20:48:03]

Done.

   X(Target_ARM32, "arm32",  false, EM_ARM,     EF_ARM_EABI_VER5)               \
   X(Target_ARM64, "arm64",  true,  EM_AARCH64, 0)                              \
   X(Target_MIPS32,"mips32", false, EM_MIPS,    0)                              \