Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: ui/views/controls/textfield/textfield_unittest.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/x/events_x.cc ('k') | ui/views/test/event_generator_delegate_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield_unittest.cc
diff --git a/ui/views/controls/textfield/textfield_unittest.cc b/ui/views/controls/textfield/textfield_unittest.cc
index d4b7d9909f9dc15029d802043c2dbe3fed772c92..dd00e40fd86f3a9e5c1c3b6b1f51d8b306c2ce2b 100644
--- a/ui/views/controls/textfield/textfield_unittest.cc
+++ b/ui/views/controls/textfield/textfield_unittest.cc
@@ -484,10 +484,11 @@ class TextfieldTest : public ViewsTestBase, public TextfieldController {
if (TestingNativeMac())
std::swap(control, command);
- int flags = (alt ? ui::EF_ALT_DOWN : 0) | (shift ? ui::EF_SHIFT_DOWN : 0) |
+ int flags = (shift ? ui::EF_SHIFT_DOWN : 0) |
(control ? ui::EF_CONTROL_DOWN : 0) |
+ (alt ? ui::EF_ALT_DOWN : 0) |
(command ? ui::EF_COMMAND_DOWN : 0) |
- (caps_lock ? ui::EF_CAPS_LOCK_DOWN : 0);
+ (caps_lock ? ui::EF_CAPS_LOCK_ON : 0);
SendKeyPress(key_code, flags);
}
« no previous file with comments | « ui/events/x/events_x.cc ('k') | ui/views/test/event_generator_delegate_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698