ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

index 53f2f894965f64888887f1f8f3d6cb0e7badced2..aee2282203074113812d4280730130ce46be2797 100644

--- a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

+++ b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

@@ -799,13 +799,13 @@ void XkbKeyboardLayoutEngine::SetKeymap(xkb_keymap* keymap) {

static const struct {

int ui_flag;

const char* xkb_name;

- } flags[] = {{ui::EF_CONTROL_DOWN, XKB_MOD_NAME_CTRL},

- {ui::EF_SHIFT_DOWN, XKB_MOD_NAME_SHIFT},

+ } flags[] = {{ui::EF_SHIFT_DOWN, XKB_MOD_NAME_SHIFT},

+ {ui::EF_CONTROL_DOWN, XKB_MOD_NAME_CTRL},

{ui::EF_ALT_DOWN, XKB_MOD_NAME_ALT},

- {ui::EF_CAPS_LOCK_DOWN, XKB_MOD_NAME_CAPS},

{ui::EF_COMMAND_DOWN, XKB_MOD_NAME_LOGO},

+ {ui::EF_ALTGR_DOWN, "Mod5"},

{ui::EF_MOD3_DOWN, "Mod3"},

- {ui::EF_ALTGR_DOWN, "Mod5"}};

+ {ui::EF_CAPS_LOCK_ON, XKB_MOD_NAME_CAPS}};

xkb_flag_map_.clear();

xkb_flag_map_.resize(arraysize(flags));

for (size_t i = 0; i < arraysize(flags); ++i) {

« no previous file with comments | « ui/events/ozone/layout/layout_util.cc ('k') | ui/events/test/events_test_utils_x11.cc » ('j') | no next file with comments »