ui/events/event.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/event.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/event.cc

diff --git a/ui/events/event.cc b/ui/events/event.cc

index 66d42780a1e9387ee5b28b371560d480755cda11..f4cf7cfd9faac42b3ce16af58e09e73c86101ee7 100644

--- a/ui/events/event.cc

+++ b/ui/events/event.cc

@@ -872,7 +872,7 @@ bool KeyEvent::IsUnicodeKeyCode() const {

// Check whether the user is using the numeric keypad with num-lock off.

// In that case, EF_EXTENDED will not be set; if it is set, the key event

// originated from the relevant non-numpad dedicated key, e.g. [Insert].

- return (!(flags() & EF_EXTENDED) &&

+ return (!(flags() & EF_IS_EXTENDED_KEY) &&

(key == VKEY_INSERT || key == VKEY_END || key == VKEY_DOWN ||

key == VKEY_NEXT || key == VKEY_LEFT || key == VKEY_CLEAR ||

key == VKEY_RIGHT || key == VKEY_HOME || key == VKEY_UP ||

« no previous file with comments | « ui/events/event.h ('k') | ui/events/event_constants.h » ('j') | no next file with comments »