ui/events/cocoa/events_mac_unittest.mm - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/cocoa/events_mac_unittest.mm

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/cocoa/events_mac_unittest.mm

diff --git a/ui/events/cocoa/events_mac_unittest.mm b/ui/events/cocoa/events_mac_unittest.mm

index 35a78523676fbb5ee246bc844972d9d6756f11c4..8a5d84a0afd31652182ed3e482293079d615b6ea 100644

--- a/ui/events/cocoa/events_mac_unittest.mm

+++ b/ui/events/cocoa/events_mac_unittest.mm

@@ -143,8 +143,7 @@ TEST_F(EventsMacTest, EventFlagsFromNative) {

// Caps + Left

NSEvent* caps = cocoa_test_event_utils::MouseEventWithType(

NSLeftMouseUp, NSAlphaShiftKeyMask);

- EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_CAPS_LOCK_DOWN,

- EventFlagsFromNative(caps));

+ EXPECT_EQ(EF_LEFT_MOUSE_BUTTON | EF_CAPS_LOCK_ON, EventFlagsFromNative(caps));

// Shift + Left

NSEvent* shift = cocoa_test_event_utils::MouseEventWithType(NSLeftMouseUp,

« no previous file with comments | « ui/events/cocoa/cocoa_event_utils.mm ('k') | ui/events/event.h » ('j') | no next file with comments »