ui/base/ime/input_method_chromeos.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_chromeos.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/ime/input_method_chromeos.cc

diff --git a/ui/base/ime/input_method_chromeos.cc b/ui/base/ime/input_method_chromeos.cc

index 8bf4014f2dc9471d029e05dbc32303a37d076f47..8062a3c6d8c53f72e5786031d73cbfaa0495555d 100644

--- a/ui/base/ime/input_method_chromeos.cc

+++ b/ui/base/ime/input_method_chromeos.cc

@@ -109,10 +109,8 @@ void InputMethodChromeOS::DispatchKeyEvent(ui::KeyEvent* event) {

if (manager) {

chromeos::input_method::ImeKeyboard* keyboard = manager->GetImeKeyboard();

if (keyboard && event->type() == ui::ET_KEY_PRESSED) {

- bool caps = (event->key_code() == ui::VKEY_CAPITAL)

- ? !keyboard->CapsLockIsEnabled()

- : (event->flags() & EF_CAPS_LOCK_DOWN);

- keyboard->SetCapsLockEnabled(caps);

+ keyboard->SetCapsLockEnabled((event->key_code() == ui::VKEY_CAPITAL) ?

+ !keyboard->CapsLockIsEnabled() : event->IsCapsLockOn());

}