Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: mojo/converters/blink/blink_input_events_type_converters.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/converters/blink/blink_input_events_type_converters.cc
diff --git a/mojo/converters/blink/blink_input_events_type_converters.cc b/mojo/converters/blink/blink_input_events_type_converters.cc
index 3700340b1b69630655f9a0966f452037127aba86..5ff67bdf37ff94de73fdf03494583eaafc5fc0ee 100644
--- a/mojo/converters/blink/blink_input_events_type_converters.cc
+++ b/mojo/converters/blink/blink_input_events_type_converters.cc
@@ -35,7 +35,7 @@ int EventFlagsToWebEventModifiers(int flags) {
modifiers |= blink::WebInputEvent::MiddleButtonDown;
if (flags & mus::mojom::EVENT_FLAGS_RIGHT_MOUSE_BUTTON)
modifiers |= blink::WebInputEvent::RightButtonDown;
- if (flags & mus::mojom::EVENT_FLAGS_CAPS_LOCK_DOWN)
+ if (flags & mus::mojom::EVENT_FLAGS_CAPS_LOCK_ON)
modifiers |= blink::WebInputEvent::CapsLockOn;
return modifiers;
}
@@ -47,11 +47,11 @@ int EventFlagsToWebInputEventModifiers(int flags) {
(flags & mus::mojom::EVENT_FLAGS_CONTROL_DOWN
? blink::WebInputEvent::ControlKey
: 0) |
- (flags & mus::mojom::EVENT_FLAGS_CAPS_LOCK_DOWN
- ? blink::WebInputEvent::CapsLockOn
- : 0) |
(flags & mus::mojom::EVENT_FLAGS_ALT_DOWN
? blink::WebInputEvent::AltKey
+ : 0) |
+ (flags & mus::mojom::EVENT_FLAGS_CAPS_LOCK_ON
+ ? blink::WebInputEvent::CapsLockOn
: 0);
}

Powered by Google App Engine
This is Rietveld 408576698