components/mus/ws/event_dispatcher_unittest.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/ws/event_dispatcher_unittest.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/ws/event_dispatcher_unittest.cc

diff --git a/components/mus/ws/event_dispatcher_unittest.cc b/components/mus/ws/event_dispatcher_unittest.cc

index ab1adc170046af89336939aef04919ebaf96c0e5..70783caf2fd989cf3023ab5c4a8e1e33760d1afb 100644

--- a/components/mus/ws/event_dispatcher_unittest.cc

+++ b/components/mus/ws/event_dispatcher_unittest.cc

@@ -223,10 +223,10 @@ TEST(EventDispatcherTest, EventMatching) {

EXPECT_EQ(accelerator_1,

event_dispatcher_delegate.GetAndClearLastAccelerator());

- // EF_NUM_LOCK_DOWN should be ignored since CreateKeyMatcher defaults to

+ // EF_NUM_LOCK_ON should be ignored since CreateKeyMatcher defaults to

// ignoring.

key = ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_W,

- ui::EF_CONTROL_DOWN | ui::EF_NUM_LOCK_DOWN);

+ ui::EF_CONTROL_DOWN | ui::EF_NUM_LOCK_ON);

dispatcher.OnEvent(mojom::Event::From(key));

EXPECT_EQ(accelerator_1,

event_dispatcher_delegate.GetAndClearLastAccelerator());