components/exo/wayland/server.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/exo/wayland/server.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/exo/wayland/server.cc

diff --git a/components/exo/wayland/server.cc b/components/exo/wayland/server.cc

index 610a61c763f56b60e51d525b973907863355b675..51d4b301f329e7c30697ea4bea8daf086dec95d9 100644

--- a/components/exo/wayland/server.cc

+++ b/components/exo/wayland/server.cc

@@ -1209,13 +1209,13 @@ class WaylandKeyboardDelegate : public KeyboardDelegate {

const char* xkb_name;

} modifiers[] = {

{ui::EF_SHIFT_DOWN, XKB_MOD_NAME_SHIFT},

- {ui::EF_CAPS_LOCK_DOWN, XKB_MOD_NAME_CAPS},

{ui::EF_CONTROL_DOWN, XKB_MOD_NAME_CTRL},

{ui::EF_ALT_DOWN, XKB_MOD_NAME_ALT},

- {ui::EF_NUM_LOCK_DOWN, XKB_MOD_NAME_NUM},

- {ui::EF_MOD3_DOWN, "Mod3"},

{ui::EF_COMMAND_DOWN, XKB_MOD_NAME_LOGO},

{ui::EF_ALTGR_DOWN, "Mod5"},

+ {ui::EF_MOD3_DOWN, "Mod3"},

+ {ui::EF_NUM_LOCK_ON, XKB_MOD_NAME_NUM},

+ {ui::EF_CAPS_LOCK_ON, XKB_MOD_NAME_CAPS},

};

uint32_t xkb_modifiers = 0;

for (auto modifier : modifiers) {