Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: components/exo/keyboard.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/libgtk2ui/gtk2_util.cc ('k') | components/exo/pointer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/keyboard.cc
diff --git a/components/exo/keyboard.cc b/components/exo/keyboard.cc
index 4a7c5c37705dd4f6569a9bb4fe5384a9fac5d449..8e307955c72998370241f903555f4276cdf1dd6f 100644
--- a/components/exo/keyboard.cc
+++ b/components/exo/keyboard.cc
@@ -36,10 +36,10 @@ Keyboard::~Keyboard() {
// ui::EventHandler overrides:
void Keyboard::OnKeyEvent(ui::KeyEvent* event) {
- const int kModifierMask = ui::EF_CAPS_LOCK_DOWN | ui::EF_SHIFT_DOWN |
- ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN |
- ui::EF_COMMAND_DOWN | ui::EF_ALTGR_DOWN |
- ui::EF_MOD3_DOWN | ui::EF_NUM_LOCK_DOWN;
+ const int kModifierMask =
+ ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN |
+ ui::EF_COMMAND_DOWN | ui::EF_ALTGR_DOWN | ui::EF_MOD3_DOWN |
+ ui::EF_NUM_LOCK_ON | ui::EF_CAPS_LOCK_ON | ui::EF_SCROLL_LOCK_ON;
reveman 2016/01/07 12:02:59 nit: please avoid adding ui::EF_SCROLL_LOCK_ON as
Peter Kasting 2016/01/07 12:15:24 Oh, I thought you had told me this would have no e
reveman 2016/01/07 12:32:36 Sorry, I failed to think of this before. It wouldn
int modifier_flags = event->flags() & kModifierMask;
if (modifier_flags != modifier_flags_) {
modifier_flags_ = modifier_flags;
« no previous file with comments | « chrome/browser/ui/libgtk2ui/gtk2_util.cc ('k') | components/exo/pointer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698