ui/events/cocoa/cocoa_event_utils.mm - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/cocoa/cocoa_event_utils.mm

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/cocoa/cocoa_event_utils.mm

diff --git a/ui/events/cocoa/cocoa_event_utils.mm b/ui/events/cocoa/cocoa_event_utils.mm

index ade083c0eb24547d7f7d1f8b6ad2f82c0ed0f1b8..ea1bd550d96f16db1349bb5b208a0c4c8a2307f3 100644

--- a/ui/events/cocoa/cocoa_event_utils.mm

+++ b/ui/events/cocoa/cocoa_event_utils.mm

@@ -36,7 +36,7 @@ namespace ui {

int EventFlagsFromModifiers(NSUInteger modifiers) {

int flags = 0;

- flags |= (modifiers & NSAlphaShiftKeyMask) ? ui::EF_CAPS_LOCK_DOWN : 0;

+ flags |= (modifiers & NSAlphaShiftKeyMask) ? ui::EF_CAPS_LOCK_ON : 0;

flags |= (modifiers & NSShiftKeyMask) ? ui::EF_SHIFT_DOWN : 0;

flags |= (modifiers & NSControlKeyMask) ? ui::EF_CONTROL_DOWN : 0;

flags |= (modifiers & NSAlternateKeyMask) ? ui::EF_ALT_DOWN : 0;