Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ui/base/ime/chromeos/character_composer.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/chromeos/character_composer.cc
diff --git a/ui/base/ime/chromeos/character_composer.cc b/ui/base/ime/chromeos/character_composer.cc
index 481e170e8d573cac8dc6f8732e9e544ac644cd7d..1a647970803300c71d7d933195305e0cd30b6ada 100644
--- a/ui/base/ime/chromeos/character_composer.cc
+++ b/ui/base/ime/chromeos/character_composer.cc
@@ -83,10 +83,10 @@ bool CharacterComposer::FilterKeyPress(const ui::KeyEvent& event) {
preedit_string_.clear();
// When the user presses Ctrl+Shift+U, maybe switch to HEX_MODE.
- // We don't care about other modifiers like Alt. When CapsLock is down, we
- // do nothing because what we receive is Ctrl+Shift+u (not U).
+ // We don't care about other modifiers like Alt. When CapsLock is on, we do
+ // nothing because what we receive is Ctrl+Shift+u (not U).
if (event.key_code() == VKEY_U &&
- (event.flags() & (EF_SHIFT_DOWN | EF_CONTROL_DOWN | EF_CAPS_LOCK_DOWN)) ==
+ (event.flags() & (EF_SHIFT_DOWN | EF_CONTROL_DOWN | EF_CAPS_LOCK_ON)) ==
(EF_SHIFT_DOWN | EF_CONTROL_DOWN)) {
if (composition_mode_ == KEY_SEQUENCE_MODE && compose_buffer_.empty()) {
// There is no ongoing composition. Let's switch to HEX_MODE.

Powered by Google App Engine
This is Rietveld 408576698