Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/bookmarks/DEPS

Issue 155913004: Eliminate Bookmarks dependence to bookmark_undo_utils.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All grouped action to notify BookmarkModelObservers Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Bookmarks is being made into a component (it will end up at 2 # Bookmarks is being made into a component (it will end up at
3 # //components/bookmarks and not depend on //chrome), so we have these basic 3 # //components/bookmarks and not depend on //chrome), so we have these basic
4 # rules followed by temporary exceptions. Please don't add to the list of 4 # rules followed by temporary exceptions. Please don't add to the list of
5 # exceptions! 5 # exceptions!
6 "-chrome/browser", 6 "-chrome/browser",
7 "+chrome/browser/bookmarks", 7 "+chrome/browser/bookmarks",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 "+chrome/browser/chrome_notification_types.h", 9 "+chrome/browser/chrome_notification_types.h",
10 "+chrome/browser/undo/bookmark_undo_service.h", 10 "+chrome/browser/undo/bookmark_undo_service.h",
11 "+chrome/browser/undo/bookmark_undo_service_factory.h", 11 "+chrome/browser/undo/bookmark_undo_service_factory.h",
12 "+chrome/browser/undo/bookmark_undo_utils.h",
13 12
14 # TODO(tfarina): Bring this list to zero. crbug.com/144783 13 # TODO(tfarina): Bring this list to zero. crbug.com/144783
15 # Do not add to the list of temporarily-allowed dependencies below, 14 # Do not add to the list of temporarily-allowed dependencies below,
16 # and please do not introduce more #includes of these files. 15 # and please do not introduce more #includes of these files.
17 "!chrome/browser/history/history_service.h", 16 "!chrome/browser/history/history_service.h",
18 "!chrome/browser/history/history_service_factory.h", 17 "!chrome/browser/history/history_service_factory.h",
19 "!chrome/browser/history/query_parser.h", 18 "!chrome/browser/history/query_parser.h",
20 "!chrome/browser/history/url_database.h", 19 "!chrome/browser/history/url_database.h",
21 "!chrome/browser/profiles/incognito_helpers.h", 20 "!chrome/browser/profiles/incognito_helpers.h",
22 "!chrome/browser/profiles/profile.h", 21 "!chrome/browser/profiles/profile.h",
23 "!chrome/browser/profiles/startup_task_runner_service.h", 22 "!chrome/browser/profiles/startup_task_runner_service.h",
24 "!chrome/browser/profiles/startup_task_runner_service_factory.h", 23 "!chrome/browser/profiles/startup_task_runner_service_factory.h",
25 # Do not add to the list of temporarily-allowed dependencies above, 24 # Do not add to the list of temporarily-allowed dependencies above,
26 # and please do not introduce more #includes of these files. 25 # and please do not introduce more #includes of these files.
27 ] 26 ]
28 27
29 specific_include_rules = { 28 specific_include_rules = {
30 # For unit tests, it's fine to include utility process code. 29 # For unit tests, it's fine to include utility process code.
31 '.*test\.cc': [ 30 '.*test\.cc': [
32 "!chrome/test/base/testing_profile.h", 31 "!chrome/test/base/testing_profile.h",
33 "+chrome/utility/importer/bookmark_html_reader.h", 32 "+chrome/utility/importer/bookmark_html_reader.h",
34 ], 33 ],
35 } 34 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.h » ('j') | chrome/browser/bookmarks/bookmark_model.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698