Issue 155913002: inline api setters in crankshaft

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155913002: inline api setters in crankshaft (Closed)

Created:
6 years, 10 months ago by dcarney

Modified:
6 years, 10 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -15 lines)			Patch
M	src/hydrogen.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+30 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	4 chunks	+26 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

LGTM. We should probably have some tests for API calls as well that verify that ...

6 years, 10 months ago (2014-02-05 21:16:59 UTC) #2

dcarney

6 years, 10 months ago (2014-02-06 07:31:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19129 (presubmit successful).