Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1559123002: Clean up resynthesis of typeArguments. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up resynthesis of typeArguments. Previously, we had to jump through hoops to properly resynthesize InterfaceTypeImpl.typeArguments and FunctionTypeImpl.typeArguments, because the correct set of type arguments depends on the number of type parameters, and that information wasn't available in the prelinked summary. Now it is. Note that typeParameters and boundTypeParameters still aren't resynthesized properly (and are untested). These will be addressed in a future CL. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/1bfb1bb612818da210bce2bb61831305552efa32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -79 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 2 chunks +13 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 2 chunks +15 lines, -72 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-04 23:51:33 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-05 00:01:13 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-05 00:13:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1bfb1bb612818da210bce2bb61831305552efa32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698