Issue 155910: Fixing the capitalized "Reset" string. Changing to lower case....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155910: Fixing the capitalized "Reset" string. Changing to lower case.... (Closed)

Created:
11 years, 5 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
xlyuan, jungshik at Google, Mark Larson

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Fixing the capitalized "Reset" string. Changing to lower case. BUG=2834 TEST=Click in "Reset to defaults" button on the options dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21498

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/app/chromium_strings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/app/google_chrome_strings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

xlyuan

On 2009/07/22 04:49:52, tfarina wrote: > Hi, thanks for your CL, hmm, I think we ...

11 years, 5 months ago (2009-07-22 17:38:49 UTC) #2

Mark Larson

Fixing this in the grd file is the right way to go. We'll pick up ...

11 years, 5 months ago (2009-07-22 17:47:26 UTC) #3

jungshik at Google

11 years, 5 months ago (2009-07-23 23:48:30 UTC) #5

Sure, I'll land it.

2009/7/23  <mal@chromium.org>:
> Jungshik, can you land this?
>
> http://codereview.chromium.org/155910
>