Issue 155908: Modified the toolbar button handler so that the handler can revert its omni...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155908: Modified the toolbar button handler so that the handler can revert its omni... (Closed)

Created:
11 years, 5 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

o Modified the toolbar button handler so that the handler can revert its omnibox when the button pressed is RELOAD, FORWARD, or BACK. o Modified Browser::Reload(). Don't revert the bar when the user hit F5 or Ctrl-r. BUG=15464 TEST=see the comment #3 of issue 15464 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21267

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/views/toolbar_view.cc	View		1 chunk	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

11 years, 5 months ago (2009-07-22 06:31:57 UTC) #3

On 2009/07/22 04:14:35, pkasting wrote:
> LGTM

Thanks. Submitted.

Expand Messages | Collapse Messages