Refs #10260 OpenBSD support #25327

runtime/bin/directory_openbsd.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
-#if defined(TARGET_OS_MACOS)
+#if defined(TARGET_OS_OPENBSD)
 
 #include "bin/directory.h"
 
 #include <dirent.h>  // NOLINT
 #include <errno.h>  // NOLINT
 #include <string.h>  // NOLINT
 #include <sys/param.h>  // NOLINT
 #include <sys/stat.h>  // NOLINT
 #include <unistd.h>  // NOLINT
 
@@ skipping 27 matching lines @@
 
 bool PathBuffer::Add(const char* name) {
   char* data = AsString();
   int written = snprintf(data + length_,
                          PATH_MAX - length_,
                          "%s",
                          name);
   data[PATH_MAX] = '\0';
   if (written <= PATH_MAX - length_ &&
       written >= 0 &&
-      static_cast<size_t>(written) == strlen(name)) {
+      static_cast<size_t>(written) == strnlen(name, PATH_MAX + 1)) {
     length_ += written;
     return true;
   } else {
     errno = ENAMETOOLONG;
     return false;
   }
 }
 
 void PathBuffer::Reset(int new_length) {
   length_ = new_length;
@@ skipping 292 matching lines @@
   // Create the directory with the permissions specified by the
   // process umask.
   int result = NO_RETRY_EXPECTED(mkdir(dir_name, 0777));
   // If the directory already exists, treat it as a success.
   if (result == -1 && errno == EEXIST) {
     return (Exists(dir_name) == EXISTS);
   }
   return (result == 0);
 }
 
-

[Ivan Posva, 2016/01/11 23:58:40]

Why? Generally we use two lines between functions.

[mulander, 2016/01/12 00:22:45]

I was not aware of that. Will be fixed.

 char* Directory::SystemTemp() {
   const char* temp_dir = getenv("TMPDIR");
   if (temp_dir == NULL) {
     temp_dir = getenv("TMP");
   }
   if (temp_dir == NULL) {
     temp_dir = "/tmp";
   }
   char* result = strdup(temp_dir);
   // Remove any trailing slash.
   int length = strlen(result);
   if (length > 1 && result[length - 1] == '/') {
     result[length - 1] = '\0';
   }
   return result;
 }
 
-

[Ivan Posva, 2016/01/11 23:58:40]

ditto

[mulander, 2016/01/12 00:22:45]

Acknowledged.

 char* Directory::CreateTemp(const char* prefix) {
   // Returns a new, unused directory name, adding characters to the end
   // of prefix.  Creates the directory with the permissions specified
   // by the process umask.
   // The return value must be freed by the caller.
   PathBuffer path;
   path.Add(prefix);
   if (!path.Add("XXXXXX")) {
     // Pattern has overflowed.
     return NULL;
@@ skipping 28 matching lines @@
 
 bool Directory::Rename(const char* path, const char* new_path) {
   ExistsResult exists = Exists(path);
   if (exists != EXISTS) return false;
   return (NO_RETRY_EXPECTED(rename(path, new_path)) == 0);
 }
 
 }  // namespace bin
 }  // namespace dart
 
-#endif  // defined(TARGET_OS_MACOS)
+#endif  // defined(TARGET_OS_OPENBSD)