Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 155904: Fix FORWARD_NULL defects reported by Coverity.... (Closed)

Created:
11 years, 5 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix FORWARD_NULL defects reported by Coverity. We should also return an error if argv is NULL. R=rvargas BUG=http://crbug.com/17101 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21292

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove incorrect change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sandbox/src/named_pipe_policy_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/src/process_policy_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
11 years, 5 months ago (2009-07-22 02:02:33 UTC) #1
rvargas (doing something else)
One of the changes is not correct. The other one LGTM. Thanks. http://codereview.chromium.org/155904/diff/1/2 File sandbox/src/process_policy_test.cc ...
11 years, 5 months ago (2009-07-22 02:56:51 UTC) #2
cpu_(ooo_6.6-7.5)
11 years, 5 months ago (2009-07-22 21:35:29 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698