Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1558983002: [Predictor CleanUp] Remove unused variables from Predictor class APIs. (Closed)

Created:
4 years, 11 months ago by Raveendra Karu
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Predictor CleanUp] Remove unused variables from Predictor class APIs. |local_state| no longer being used in Predictor. So it is safe to remove. BUG=573994 Committed: https://crrev.com/97260304e8db087e6641164a5539ed04b2bfb104 Cr-Commit-Position: refs/heads/master@{#367818}

Patch Set 1 #

Patch Set 2 : Fixed lint errors. #

Patch Set 3 : Removed usage of local_state in initPredictor() API, fixed lint errors #

Total comments: 4

Patch Set 4 : Addresses mmenke's review inputs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/predictor.h View 1 2 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 2 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 3 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Pritam Nikam
Hi Ravi, Please have a look. Thanks!
4 years, 11 months ago (2016-01-04 12:37:30 UTC) #2
RaviKasibhatla
Broadly looks ok with one nit. But IMHO it might be better to wait for ...
4 years, 11 months ago (2016-01-05 05:36:53 UTC) #5
Raveendra Karu
https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/net/predictor.h File chrome/browser/net/predictor.h (left): https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/net/predictor.h#oldcode30 chrome/browser/net/predictor.h:30: #include <stdint.h> On 2016/01/05 05:36:53, RaviKasibhatla wrote: > I ...
4 years, 11 months ago (2016-01-05 05:57:25 UTC) #6
mmenke
And for the record, I verified that Raveendra Karu has signed the CLA. https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/profiles/profile_impl_io_data.cc File ...
4 years, 11 months ago (2016-01-05 16:41:46 UTC) #8
Raveendra Karu
Thanks mmenke for review. I've incorporated the review inputs in my new patch set, PTAL. ...
4 years, 11 months ago (2016-01-06 06:04:24 UTC) #10
mmenke
LGTM, thanks for the cleanup!
4 years, 11 months ago (2016-01-06 13:13:26 UTC) #11
Raveendra Karu
On 2016/01/06 13:13:26, mmenke wrote: > LGTM, thanks for the cleanup! Thanks mmenke. I'll go ...
4 years, 11 months ago (2016-01-06 13:16:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558983002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558983002/60001
4 years, 11 months ago (2016-01-06 13:17:24 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-06 14:08:41 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 14:09:38 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/97260304e8db087e6641164a5539ed04b2bfb104
Cr-Commit-Position: refs/heads/master@{#367818}

Powered by Google App Engine
This is Rietveld 408576698