[Predictor CleanUp] Remove unused variables from Predictor class APIs.

[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994
Committed: https://crrev.com/97260304e8db087e6641164a5539ed04b2bfb104
Cr-Commit-Position: refs/heads/master@{#367818}

[Pritam Nikam, 2016-01-04 12:37:29]

pritam.nikam@samsung.com changed reviewers:
+ pritam.nikam@samsung.com, r.kasibhatla@samsung.com

[Pritam Nikam, 2016-01-04 12:37:30]

Hi Ravi,
Please have a look.
Thanks!

[Raveendra Karu, 2016-01-04 12:38:53]

Description was changed from

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994
==========

to

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994

R=SamsungPeerReview
==========

[RaviKasibhatla, 2016-01-05 05:36:52]

kphanee@chromium.org changed reviewers:
+ kphanee@chromium.org

[RaviKasibhatla, 2016-01-05 05:36:53]

Broadly looks ok with one nit.

But IMHO it might be better to wait for some response from dir/module owner on
the raised issue before we publish it for review. Earlier, we have seen some
clean up patches being not accepted to reduce the code change churn. Once the
owner does agree for the cleanup, we can publish it.

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/net/pred...
File chrome/browser/net/predictor.h (left):

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/net/pred...
chrome/browser/net/predictor.h:30: #include <stdint.h>
I am not sure about this change. This change is unrelated to the raised issue or
required code changes.

[Raveendra Karu, 2016-01-05 05:57:25]

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/net/pred...
File chrome/browser/net/predictor.h (left):

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/net/pred...
chrome/browser/net/predictor.h:30: #include <stdint.h>
On 2016/01/05 05:36:53, RaviKasibhatla wrote:
> I am not sure about this change. This change is unrelated to the raised issue
or
> required code changes.

These are lint error fixes. As it is clean up patch, fixed these lint errors as
well. Similar lint related errors are fixed in other file
|profile_impl_io_data.cc| also.

[mmenke, 2016-01-05 16:41:45]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2016-01-05 16:41:46]

And for the record, I verified that Raveendra Karu has signed the CLA.

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/profiles...
File chrome/browser/profiles/profile_impl_io_data.cc (right):

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/profiles...
chrome/browser/profiles/profile_impl_io_data.cc:227: PrefService* local_state,
Think we can remove local_state here, too.

[Raveendra Karu, 2016-01-06 06:02:31]

Description was changed from

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994

R=SamsungPeerReview
==========

to

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994
==========

[Raveendra Karu, 2016-01-06 06:04:24]

Thanks mmenke for review. I've incorporated the review inputs in my new patch
set, PTAL.
Thanks!

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/profiles...
File chrome/browser/profiles/profile_impl_io_data.cc (right):

https://codereview.chromium.org/1558983002/diff/40001/chrome/browser/profiles...
chrome/browser/profiles/profile_impl_io_data.cc:227: PrefService* local_state,
On 2016/01/05 16:41:46, mmenke wrote:
> Think we can remove local_state here, too.

Done.

[mmenke, 2016-01-06 13:13:26]

LGTM, thanks for the cleanup!

[Raveendra Karu, 2016-01-06 13:16:59]

On 2016/01/06 13:13:26, mmenke wrote:
> LGTM, thanks for the cleanup!

Thanks mmenke. I'll go ahead with commit.

[Raveendra Karu, 2016-01-06 13:17:09]

The CQ bit was checked by r.karu@samsung.com

[commit-bot: I haz the power, 2016-01-06 13:17:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558983002/60001

[commit-bot: I haz the power, 2016-01-06 14:08:40]

Description was changed from

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994
==========

to

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994
==========

[commit-bot: I haz the power, 2016-01-06 14:08:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-06 14:09:38]

Description was changed from

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994
==========

to

==========
[Predictor CleanUp] Remove unused variables from Predictor class APIs.

|local_state| no longer being used in Predictor. So it is safe to remove.

BUG=573994

Committed: https://crrev.com/97260304e8db087e6641164a5539ed04b2bfb104
Cr-Commit-Position: refs/heads/master@{#367818}
==========

[commit-bot: I haz the power, 2016-01-06 14:09:38]

Patchset 4 (id:??) landed as
https://crrev.com/97260304e8db087e6641164a5539ed04b2bfb104
Cr-Commit-Position: refs/heads/master@{#367818}