Recalculate column heights as part of column set layout.

Recalculate column heights as part of column set layout.

This is a tad earlier than what we used to do; we used to do it for all sets in
one go at the end of layout of the multicol container. We now do it
individually for each column set (children of the multicol container) as we lay
them out.

This way we have an up-to-date column height when positioning column sets
during multicol container child layout (children being either spanner
placeholders or column sets).

For the bug in question, this is particularly important in the first layout
pass, where column heights are completely bogus. When we're in a nested
fragmentation context, inner column heights are typically set to the remaining
height of an outer column, which may be more space than the contents actually
need. This could in turn trick the machinery into believing that we need to
insert another fragmentainer group for a spanner following a column set, even
if column heights were completely unconstrained.

BUG=552615
R=leviw@chromium.org

Committed: https://crrev.com/5b549adb97c791f7e3362c529deecc702b3443d4
Cr-Commit-Position: refs/heads/master@{#369366}

[leviw_travelin_and_unemployed, 2016-01-14 00:25:59]

FYI: I'm just starting to pop these off the end of the queue.

[leviw_travelin_and_unemployed, 2016-01-14 00:30:14]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2016-01-14 00:30:15]

lgtm

[commit-bot: I haz the power, 2016-01-14 00:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558963003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558963003/1

[commit-bot: I haz the power, 2016-01-14 02:39:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 02:39:05]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)

[mstensho (USE GERRIT), 2016-01-14 07:46:02]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-01-14 07:46:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558963003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558963003/1

[commit-bot: I haz the power, 2016-01-14 07:50:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-14 07:52:36]

Description was changed from

==========
Recalculate column heights as part of column set layout.

This is a tad earlier than what we used to do; we used to do it for all sets in
one go at the end of layout of the multicol container. We now do it
individually for each column set (children of the multicol container) as we lay
them out.

This way we have an up-to-date column height when positioning column sets
during multicol container child layout (children being either spanner
placeholders or column sets).

For the bug in question, this is particularly important in the first layout
pass, where column heights are completely bogus. When we're in a nested
fragmentation context, inner column heights are typically set to the remaining
height of an outer column, which may be more space than the contents actually
need. This could in turn trick the machinery into believing that we need to
insert another fragmentainer group for a spanner following a column set, even
if column heights were completely unconstrained.

BUG=552615
R=leviw@chromium.org
==========

to

==========
Recalculate column heights as part of column set layout.

This is a tad earlier than what we used to do; we used to do it for all sets in
one go at the end of layout of the multicol container. We now do it
individually for each column set (children of the multicol container) as we lay
them out.

This way we have an up-to-date column height when positioning column sets
during multicol container child layout (children being either spanner
placeholders or column sets).

For the bug in question, this is particularly important in the first layout
pass, where column heights are completely bogus. When we're in a nested
fragmentation context, inner column heights are typically set to the remaining
height of an outer column, which may be more space than the contents actually
need. This could in turn trick the machinery into believing that we need to
insert another fragmentainer group for a spanner following a column set, even
if column heights were completely unconstrained.

BUG=552615
R=leviw@chromium.org

Committed: https://crrev.com/5b549adb97c791f7e3362c529deecc702b3443d4
Cr-Commit-Position: refs/heads/master@{#369366}
==========

[commit-bot: I haz the power, 2016-01-14 07:52:39]

Patchset 1 (id:??) landed as
https://crrev.com/5b549adb97c791f7e3362c529deecc702b3443d4
Cr-Commit-Position: refs/heads/master@{#369366}