Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1558933002: move SkDither.h to private, remove unused shadeSpan16 (Closed)

Created:
4 years, 11 months ago by reed2
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move SkDither.h to private, remove unused shadeSpan16 Since perlin noise shader never set the kHasShad16 flag, its shadeSpan16 method was never called. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1558933002 TBR= Committed: https://skia.googlesource.com/skia/+/03f896810677bf648d110123ebaf6a8a7af2a667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -213 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
D include/core/SkDither.h View 1 chunk +0 lines, -198 lines 0 comments Download
M include/effects/SkPerlinNoiseShader.h View 1 chunk +0 lines, -1 line 0 comments Download
A + src/core/SkDither.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558933002/1
4 years, 11 months ago (2016-01-04 03:25:31 UTC) #3
reed2
4 years, 11 months ago (2016-01-04 03:30:27 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 03:39:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558933002/1
4 years, 11 months ago (2016-01-04 13:05:22 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 13:06:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/03f896810677bf648d110123ebaf6a8a7af2a667

Powered by Google App Engine
This is Rietveld 408576698