Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1558903002: Suppress -Wunused-function for nss. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/nss.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress -Wunused-function for nss. In iOS builds: ../../third_party/nss/nss/lib/freebl/sysrand.c:31:1: warning: unused function 'rng_systemFromNoise' [-Wunused-function] rng_systemFromNoise(unsigned char *dest, size_t maxLen) ^ BUG=573779 R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/nss/+/225bfc39c93dfb7c7d0d1162f81e9bb5cd356c30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M nss.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
4 years, 11 months ago (2016-01-03 23:26:39 UTC) #2
Nico
Mark, want to stamp this? Looks like David might be travelling.
4 years, 11 months ago (2016-01-04 17:27:20 UTC) #4
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-04 17:28:42 UTC) #5
Nico
4 years, 11 months ago (2016-01-04 17:38:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
225bfc39c93dfb7c7d0d1162f81e9bb5cd356c30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698