Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1558843002: First step towards a public API for AST nodes (Closed)

Created:
4 years, 11 months ago by Brian Wilkerson
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add new files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15283 lines, -15228 lines) Patch
A pkg/analyzer/lib/dart/ast/visitor.dart View 1 1 chunk +1884 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 1 chunk +6272 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 13 chunks +7127 lines, -15228 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
Despite the fact that diff got really confused about what has changed, the only thing ...
4 years, 11 months ago (2015-12-31 21:27:30 UTC) #1
Brian Wilkerson
4 years, 11 months ago (2016-01-04 17:19:46 UTC) #3
scheglov
LGTM
4 years, 11 months ago (2016-01-04 17:30:06 UTC) #4
Paul Berry
lgtm
4 years, 11 months ago (2016-01-04 18:11:41 UTC) #5
Brian Wilkerson
4 years, 11 months ago (2016-01-04 18:44:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dff4089ff21650d984f85e2a44f959e630406cf3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698