Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chrome/plugin/plugin_thread.cc

Issue 155881: Remove the NOTIMPLEMENTED from IsDefaultPluginEnabled for Mac (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/plugin/plugin_thread.h" 5 #include "chrome/plugin/plugin_thread.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 return true; 164 return true;
165 } 165 }
166 166
167 bool IsDefaultPluginEnabled() { 167 bool IsDefaultPluginEnabled() {
168 #if defined(OS_WIN) 168 #if defined(OS_WIN)
169 return true; 169 return true;
170 #elif defined(OS_LINUX) 170 #elif defined(OS_LINUX)
171 // http://code.google.com/p/chromium/issues/detail?id=10952 171 // http://code.google.com/p/chromium/issues/detail?id=10952
172 return false; 172 return false;
173 #elif defined(OS_MACOSX) 173 #elif defined(OS_MACOSX)
174 NOTIMPLEMENTED(); 174 // http://code.google.com/p/chromium/issues/detail?id=17392
175 return false; 175 return false;
176 #endif 176 #endif
177 } 177 }
178 178
179 // Dispatch the resolve proxy resquest to the right code, depending on which 179 // Dispatch the resolve proxy resquest to the right code, depending on which
180 // process the plugin is running in {renderer, browser, plugin}. 180 // process the plugin is running in {renderer, browser, plugin}.
181 bool FindProxyForUrl(const GURL& url, std::string* proxy_list) { 181 bool FindProxyForUrl(const GURL& url, std::string* proxy_list) {
182 int net_error; 182 int net_error;
183 std::string proxy_result; 183 std::string proxy_result;
184 184
185 bool result; 185 bool result;
186 if (IsPluginProcess()) { 186 if (IsPluginProcess()) {
187 result = PluginThread::current()->Send( 187 result = PluginThread::current()->Send(
188 new PluginProcessHostMsg_ResolveProxy(url, &net_error, &proxy_result)); 188 new PluginProcessHostMsg_ResolveProxy(url, &net_error, &proxy_result));
189 } else { 189 } else {
190 result = RenderThread::current()->Send( 190 result = RenderThread::current()->Send(
191 new ViewHostMsg_ResolveProxy(url, &net_error, &proxy_result)); 191 new ViewHostMsg_ResolveProxy(url, &net_error, &proxy_result));
192 } 192 }
193 193
194 if (!result || net_error != net::OK) 194 if (!result || net_error != net::OK)
195 return false; 195 return false;
196 196
197 *proxy_list = proxy_result; 197 *proxy_list = proxy_result;
198 return true; 198 return true;
199 } 199 }
200 200
201 } // namespace webkit_glue 201 } // namespace webkit_glue
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698