third_party/WebKit/LayoutTests/http/tests/cache/sync-xhr-304-expected.txt - Issue 1558703002: Synchronous requests that get a 304 clobber the cached response body.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/cache/sync-xhr-304-expected.txt

Issue 1558703002: Synchronous requests that get a 304 clobber the cached response body. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/cache/sync-xhr-304.html ('k') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/cache/sync-xhr-304-expected.txt

diff --git a/third_party/WebKit/LayoutTests/dom/svg/level3/xpath/Attribute_Nodes-expected.txt b/third_party/WebKit/LayoutTests/http/tests/cache/sync-xhr-304-expected.txt

similarity index 55%

copy from third_party/WebKit/LayoutTests/dom/svg/level3/xpath/Attribute_Nodes-expected.txt

copy to third_party/WebKit/LayoutTests/http/tests/cache/sync-xhr-304-expected.txt

index 2b35a89079b26bd089960b5c6f3f913f4d5b1c73..fc922384b3fcff59a66e6d2899f42a48075c98f3 100644

--- a/third_party/WebKit/LayoutTests/dom/svg/level3/xpath/Attribute_Nodes-expected.txt

+++ b/third_party/WebKit/LayoutTests/http/tests/cache/sync-xhr-304-expected.txt

@@ -1,2 +1,3 @@

CONSOLE WARNING: Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

-Attribute_Nodes: Success

+Send 2 sync xhrs to the same url such that the 2nd should return a 304. Ensure that the responseText for the 2nd XHR is non-empty.

+xhr2.responseText: foo