Remove redundant calls to Pass() in //net unit tests..

Remove redundant calls to Pass() in //net unit tests..

There is no need to Pass() on rvalues: in fact, it prevents the compiler
from applying optimizations like copy/move elision.

BUG=557422
TBR=rsleevi@chromium.org

Committed: https://crrev.com/a96b7d399aaa591595df7e6d6b007d625c5cf7b9
Cr-Commit-Position: refs/heads/master@{#367166}

[dcheng, 2015-12-30 18:31:07]

Description was changed from

==========
Remove redundant calls to Pass() in //net unit tests..

There is no need to Pass() on rvalues: in fact, it prevents the compiler
from applying optimizations like copy/move elision.

BUG=557422
CC=eustas@chromium.org
TBR=rsleevi@chromium.org
==========

to

==========
Remove redundant calls to Pass() in //net unit tests..

There is no need to Pass() on rvalues: in fact, it prevents the compiler
from applying optimizations like copy/move elision.

BUG=557422
TBR=rsleevi@chromium.org
==========

[dcheng, 2015-12-30 18:31:08]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-12-30 18:32:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558623002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558623002/1

[Ryan Sleevi, 2015-12-30 18:38:12]

lgtm

[commit-bot: I haz the power, 2015-12-30 18:58:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-30 18:59:52]

Description was changed from

==========
Remove redundant calls to Pass() in //net unit tests..

There is no need to Pass() on rvalues: in fact, it prevents the compiler
from applying optimizations like copy/move elision.

BUG=557422
TBR=rsleevi@chromium.org
==========

to

==========
Remove redundant calls to Pass() in //net unit tests..

There is no need to Pass() on rvalues: in fact, it prevents the compiler
from applying optimizations like copy/move elision.

BUG=557422
TBR=rsleevi@chromium.org

Committed: https://crrev.com/a96b7d399aaa591595df7e6d6b007d625c5cf7b9
Cr-Commit-Position: refs/heads/master@{#367166}
==========

[commit-bot: I haz the power, 2015-12-30 18:59:52]

Patchset 1 (id:??) landed as
https://crrev.com/a96b7d399aaa591595df7e6d6b007d625c5cf7b9
Cr-Commit-Position: refs/heads/master@{#367166}

[eustas, 2015-12-30 19:09:43]

eustas@chromium.org changed reviewers:
+ eustas@chromium.org

[eustas, 2015-12-30 19:09:44]

lgtm

Interesting - presubmit has recommended to remove .Pass() in one place, but did
not notice it here...

[dcheng, 2015-12-30 19:10:44]

On 2015/12/30 at 19:09:44, eustas wrote:
> lgtm
> 
> Interesting - presubmit has recommended to remove .Pass() in one place, but
did not notice it here...

The regex the presubmit uses won't match if .Pass() is on a separate line from
the rest of the expression. One of the (many) problems with a regex based lint.