components/data_reduction_proxy.gypi - Issue 1558553002: Lo-Fi snackbar should only be shown for the first q=low response of a page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy.gypi

Issue 1558553002: Lo-Fi snackbar should only be shown for the first q=low response of a page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tbansal comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc ('K') | « components/components_tests.gyp ('k') | components/data_reduction_proxy/content/browser/BUILD.gn » ('j') | components/data_reduction_proxy/content/browser/content_lofi_ui_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy.gypi

diff --git a/components/data_reduction_proxy.gypi b/components/data_reduction_proxy.gypi

index 9ff6000f1803ecfd67e71974501f488c628204cb..67266c63747dbfc3d64c17d8a131efadcdf54738 100644

--- a/components/data_reduction_proxy.gypi

+++ b/components/data_reduction_proxy.gypi

@@ -81,6 +81,8 @@

'data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h',

'data_reduction_proxy/core/common/data_reduction_proxy_switches.cc',

'data_reduction_proxy/core/common/data_reduction_proxy_switches.h',

+ 'data_reduction_proxy/core/common/lofi_decider.h',

+ 'data_reduction_proxy/core/common/lofi_ui_service.h',

'conditions': [

@@ -132,7 +134,6 @@

'dependencies': [

'../base/base.gyp:base',

'../content/content.gyp:content_browser',

- '../skia/skia.gyp:skia',

'../ui/base/ui_base.gyp:ui_base',

'components_resources.gyp:components_resources',

'components_strings.gyp:components_strings',

@@ -175,12 +176,15 @@

'dependencies': [

'../content/content.gyp:content_common',

'../ipc/ipc.gyp:ipc',

+ '../skia/skia.gyp:skia',

tbansal1 2016/01/05 21:07:09 Is this dependency needed?

megjablon 2016/01/06 17:20:47 It's needed for the WebContents include: "FAILED:

'data_reduction_proxy_content_common',

'include_dirs': [

'..',

'sources': [

+ 'data_reduction_proxy/content/browser/content_lofi_ui_service.cc',

+ 'data_reduction_proxy/content/browser/content_lofi_ui_service.h',

'data_reduction_proxy/content/browser/content_lofi_decider.cc',

'data_reduction_proxy/content/browser/content_lofi_decider.h',

'data_reduction_proxy/content/browser/data_reduction_proxy_message_filter.cc',