Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/renderer/media/media_stream_video_source_unittest.cc

Issue 155853002: Chrome MediaStream VideoTrack implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More cleanup. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_source_unittest.cc
diff --git a/content/renderer/media/media_stream_video_source_unittest.cc b/content/renderer/media/media_stream_video_source_unittest.cc
index 1060b04ad260d89e50e86d01f7f989a4a48668da..092502647a310099daee20af8f1e2388c7bcab4f 100644
--- a/content/renderer/media/media_stream_video_source_unittest.cc
+++ b/content/renderer/media/media_stream_video_source_unittest.cc
@@ -8,6 +8,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "content/renderer/media/media_stream_video_source.h"
+#include "content/renderer/media/media_stream_video_track.h"
#include "content/renderer/media/mock_media_stream_dependency_factory.h"
#include "content/renderer/media/mock_media_stream_video_source.h"
#include "media/base/video_frame.h"
@@ -81,17 +82,17 @@ class MediaStreamVideoSourceTest
blink::WebMediaStreamTrack CreateTrack(
const std::string& id,
const blink::WebMediaConstraints& constraints) {
+
blink::WebMediaStreamTrack track;
track.initialize(base::UTF8ToUTF16(id), webkit_source_);
-
- MediaStreamVideoSource* source =
- static_cast<MediaStreamVideoSource*>(track.source().extraData());
-
- source->AddTrack(track,
- constraints,
- base::Bind(
- &MediaStreamVideoSourceTest::OnConstraintsApplied,
- base::Unretained(this)));
+ track.setExtraData(new MediaStreamVideoTrack(mock_source_, NULL));
+
+ mock_source_->AddTrack(
+ track,
+ constraints,
+ base::Bind(
+ &MediaStreamVideoSourceTest::OnConstraintsApplied,
+ base::Unretained(this)));
return track;
}
@@ -151,7 +152,7 @@ class MediaStreamVideoSourceTest
TEST_F(MediaStreamVideoSourceTest, AddTrackAndStartSource) {
blink::WebMediaConstraints constraints;
constraints.initialize();
- blink::WebMediaStreamTrack track = CreateTrack("123", constraints);
+ CreateTrack("123", constraints);
mock_source()->CompleteGetSupportedFormats();
mock_source()->StartMockedSource();
EXPECT_EQ(1, NumberOfSuccessConstraintsCallbacks());
@@ -171,18 +172,18 @@ TEST_F(MediaStreamVideoSourceTest, AddTwoTracksBeforeSourceStarts) {
TEST_F(MediaStreamVideoSourceTest, AddTrackAfterSourceStarts) {
blink::WebMediaConstraints constraints;
constraints.initialize();
- blink::WebMediaStreamTrack track1 = CreateTrack("123", constraints);
+ CreateTrack("123", constraints);
mock_source()->CompleteGetSupportedFormats();
mock_source()->StartMockedSource();
EXPECT_EQ(1, NumberOfSuccessConstraintsCallbacks());
- blink::WebMediaStreamTrack track2 = CreateTrack("123", constraints);
+ CreateTrack("123", constraints);
EXPECT_EQ(2, NumberOfSuccessConstraintsCallbacks());
}
TEST_F(MediaStreamVideoSourceTest, AddTrackAndFailToStartSource) {
blink::WebMediaConstraints constraints;
constraints.initialize();
- blink::WebMediaStreamTrack track = CreateTrack("123", constraints);
+ CreateTrack("123", constraints);
mock_source()->CompleteGetSupportedFormats();
mock_source()->FailToStartMockedSource();
EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());
@@ -191,8 +192,8 @@ TEST_F(MediaStreamVideoSourceTest, AddTrackAndFailToStartSource) {
TEST_F(MediaStreamVideoSourceTest, AddTwoTracksBeforeGetSupportedFormats) {
blink::WebMediaConstraints constraints;
constraints.initialize();
- blink::WebMediaStreamTrack track1 = CreateTrack("123", constraints);
- blink::WebMediaStreamTrack track2 = CreateTrack("123", constraints);
+ CreateTrack("123", constraints);
+ CreateTrack("123", constraints);
mock_source()->CompleteGetSupportedFormats();
mock_source()->StartMockedSource();
EXPECT_EQ(2, NumberOfSuccessConstraintsCallbacks());
@@ -236,7 +237,7 @@ TEST_F(MediaStreamVideoSourceTest, MandatoryAspectRatio4To3) {
CreateTrackAndStartSource(factory.CreateConstraints(), 640, 480, 30);
}
-// Test that ApplyConstraints fail if the mandatory aspect ratio
+// Test that AddTrack fail if the mandatory aspect ratio
// is set higher than supported.
TEST_F(MediaStreamVideoSourceTest, MandatoryAspectRatioTooHigh) {
ConstraintsFactory factory;
@@ -283,7 +284,6 @@ TEST_F(MediaStreamVideoSourceTest, DefaultCapability) {
TEST_F(MediaStreamVideoSourceTest, InvalidMandatoryConstraint) {
ConstraintsFactory factory;
factory.AddMandatory("weird key", 640);
-
CreateTrack("123", factory.CreateConstraints());
mock_source()->CompleteGetSupportedFormats();
EXPECT_EQ(1, NumberOfFailedConstraintsCallbacks());

Powered by Google App Engine
This is Rietveld 408576698