content/renderer/media/media_stream_audio_source.h - Issue 155853002: Chrome MediaStream VideoTrack implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_source.h

Issue 155853002: Chrome MediaStream VideoTrack implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed a comment. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_stream_audio_source.h

diff --git a/content/renderer/media/media_stream_audio_source.h b/content/renderer/media/media_stream_audio_source.h

index 2e73395f7b5acc55abb303b9d41e5667b5105446..35e121108a645ac052855a4080fe6e8c200855a8 100644

--- a/content/renderer/media/media_stream_audio_source.h

+++ b/content/renderer/media/media_stream_audio_source.h

@@ -26,8 +26,7 @@ class CONTENT_EXPORT MediaStreamAudioSource

virtual void AddTrack(const blink::WebMediaStreamTrack& track,

no longer working on chromium 2014/03/02 10:57:36 can we remove virtual since it it not overriding a

perkj_chrome 2014/03/04 10:44:51 Done.

const blink::WebMediaConstraints& constraints,

- const ConstraintsCallback& callback) OVERRIDE;

- virtual void RemoveTrack(const blink::WebMediaStreamTrack& track) OVERRIDE;

+ const ConstraintsCallback& callback);

Ronghua Wu (Left Chromium) 2014/03/04 01:04:11 why remove OVERRIDE but not virtual?

perkj_chrome 2014/03/04 10:44:51 Done.

void SetLocalAudioSource(webrtc::AudioSourceInterface* source) {

local_audio_source_ = source;