Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1558513002: Global conversion of Pass()→std::move() on OS=linux (GYP edition) (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
jam, vmpstr
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Global conversion of Pass()→std::move() on OS=linux (GYP edition) A few more things that are present in GYP builds but not GN builds... (╯^□^)╯︵ ❄☃❄ BUG=557422 R=vmpstr@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/27f7483ff7bb09a1364bcc90241b4b50608ff46b Cr-Commit-Position: refs/heads/master@{#367108}

Patch Set 1 #

Patch Set 2 : Depessimized, sort of #

Patch Set 3 : formatted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 6 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/nacl/pnacl_header_test.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M components/exo/buffer.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M components/exo/shared_memory.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M components/exo/surface.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M components/exo/wayland/server.cc View 1 2 10 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dcheng
4 years, 11 months ago (2015-12-29 21:18:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558513002/40001
4 years, 11 months ago (2015-12-29 21:18:48 UTC) #5
vmpstr
(non-owner) lgtm
4 years, 11 months ago (2015-12-29 21:21:27 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-29 22:16:21 UTC) #8
dcheng
(TBRing jam for global commit approval)
4 years, 11 months ago (2015-12-29 22:18:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558513002/40001
4 years, 11 months ago (2015-12-29 22:18:48 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-29 22:27:04 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 22:28:09 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/27f7483ff7bb09a1364bcc90241b4b50608ff46b
Cr-Commit-Position: refs/heads/master@{#367108}

Powered by Google App Engine
This is Rietveld 408576698