Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1558433002: [runtime] Migrate Object.create to C++. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Migrate Object.create to C++. There's no point in keeping the ObjectCreate JavaScript wrapper function, which even does allocation site pretenuring for the instances created via Object.create (where ObjectCreate itself is the AllocationSite), and does not offer any sane way forward. Instead introduce a new ObjectCreate C++ builtin, which currently serves as a baseline implementation, on top of which we can think about ways to optimize Object.create for the common case (i.e. frameworks such as Ember.js make heavy use of Object.create). R=cbruni@chromium.org TBR=hpayer@chromium.org Committed: https://crrev.com/6a51d31139500b8e4182bc8f0b3a942bdbc02d3e Cr-Commit-Position: refs/heads/master@{#33061}

Patch Set 1 #

Patch Set 2 : Fix length #

Total comments: 2

Patch Set 3 : Address Camillos comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -33 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +0 lines, -13 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.cc View 4 chunks +17 lines, -14 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
4 years, 11 months ago (2015-12-29 18:45:27 UTC) #1
Benedikt Meurer
Hey Camillo, Another easy one. As discussed before christmas, we want to make Object.create better ...
4 years, 11 months ago (2015-12-29 18:47:17 UTC) #2
Camillo Bruni
LGTM with one nit (that you can ignore) https://codereview.chromium.org/1558433002/diff/20001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1558433002/diff/20001/src/builtins.cc#newcode1516 src/builtins.cc:1516: Handle<Object> ...
4 years, 11 months ago (2015-12-30 08:54:30 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1558433002/diff/20001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1558433002/diff/20001/src/builtins.cc#newcode1516 src/builtins.cc:1516: Handle<Object> properties = args.at<Object>(2); Hah, gotcha :-)
4 years, 11 months ago (2015-12-30 13:13:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558433002/40001
4 years, 11 months ago (2015-12-30 13:14:09 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-30 14:16:12 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 14:16:27 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a51d31139500b8e4182bc8f0b3a942bdbc02d3e
Cr-Commit-Position: refs/heads/master@{#33061}

Powered by Google App Engine
This is Rietveld 408576698