Issue 155843006: Omit redundant smi checks in write barriers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155843006: Omit redundant smi checks in write barriers. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer

Modified:
6 years, 10 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Omit redundant smi checks in write barriers. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19323

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -10 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Committed patchset #1 manually as r19323 (presubmit successful).

6 years, 10 months ago (2014-02-12 12:36:59 UTC) #3

rmcilroy

6 years, 10 months ago (2014-02-12 12:38:04 UTC) #4

Message was sent while issue was closed.

On 2014/02/12 12:36:59, Benedikt Meurer wrote:
> Committed patchset #1 manually as r19323 (presubmit successful).

Please do this for A64 as well if applicable.

Expand Messages | Collapse Messages