'linux' platform should exclude 'chromeos' in json compiler.

'linux' platform should exclude 'chromeos' in json compiler.

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None

Committed: https://crrev.com/dccc97f4646d4752eddf5c2a48542c794e313403
Cr-Commit-Position: refs/heads/master@{#369346}

[Shu Chen, 2016-01-06 03:47:27]

shuchen@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Shu Chen, 2016-01-06 03:47:27]

Devlin, can you please review this cl? Thanks

[Devlin, 2016-01-07 22:55:29]

can we add/update a unittest?

[Shu Chen, 2016-01-08 01:25:32]

On 2016/01/07 22:55:29, Devlin wrote:
> can we add/update a unittest?

Done. Can you please take another look?

[Devlin, 2016-01-11 21:36:05]

On 2016/01/08 01:25:32, Shu Chen wrote:
> On 2016/01/07 22:55:29, Devlin wrote:
> > can we add/update a unittest?
> 
> Done. Can you please take another look?

Good start, but I was hoping we can add a test that checks the generated code
has the proper if defined logic.

[Shu Chen, 2016-01-12 04:52:37]

On 2016/01/11 21:36:05, Devlin wrote:
> On 2016/01/08 01:25:32, Shu Chen wrote:
> > On 2016/01/07 22:55:29, Devlin wrote:
> > > can we add/update a unittest?
> > 
> > Done. Can you please take another look?
> 
> Good start, but I was hoping we can add a test that checks the generated code
> has the proper if defined logic.

I just found that the extension API functions for 'linux_desktop' doesn't work.
The root cause is in extensions/renderer/resources/binding.js,
isPlatformSupported() function
returns false on linux desktop.
That makes me think that there should be no 'linux_desktop' platform, the
original 'linux' platform
was designed to support only for linux desktop, and didn't mean to include
'chromeos'.
Otherwise, for ("platforms": ["linux"]), isPlatformSupported() in on Chrome OS
will return false.

Because of that, there should be no existing JSON/IDLE files are using 'linux'
to include 'cros'.
I will upload a new patch to reflect the change soon.

[Shu Chen, 2016-01-12 05:07:55]

Description was changed from

==========
Support 'linux_desktop' platform to exclude 'chromeos' in json compiler.

This is to support the new IME API, which is defined in input_ime.json
but has some unique functions for chromeos & non-chromeos platforms.
But currently the platform 'linux' covers 'chromeos', so the compiler
needs to support 'linux' platform excludes 'chromeos'.

BUG=517773
TEST=None
==========

to

==========
'linux' platform should exclude 'chromeos' in json compiler.

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None
==========

[Shu Chen, 2016-01-12 05:08:07]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-12 05:08:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558413002/40001

[Shu Chen, 2016-01-12 05:31:23]

Hi Devlin, I've uploaded the new patch.

Would you still expect a test for macro checks?
I suppose the CQ should be enough to find out any wrong generated ifdefs.

[commit-bot: I haz the power, 2016-01-12 06:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 06:25:52]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-01-13 01:33:48]

On 2016/01/12 05:31:23, Shu Chen wrote:
> Hi Devlin, I've uploaded the new patch.
> 
> Would you still expect a test for macro checks?
> I suppose the CQ should be enough to find out any wrong generated ifdefs.

I think I would still like a test, yeah.  In the latest patch set, it shows that
CQ isn't necessary enough (since if it were, the existing code would fail,
right?).  I would expect it to be a very straight-forward test, so maybe worth
the low cost of writing it.  If it turns out to be trickier than that, though,
lemme know - I don't want you to pour a significant number of work hours into
it.

[Shu Chen, 2016-01-13 07:39:53]

Hi Devlin, I've added the tests. Please take another look. Thanks

[Devlin, 2016-01-13 17:54:33]

awesome!  LGTM.

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/cpp_bundle_generator_test.py (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/cpp_bundle_generator_test.py:2: # Copyright (c) 2012
The Chromium Authors. All rights reserved.
update

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/test/function_platform_all.json (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/test/function_platform_all.json:1: // Copyright (c)
2016 The Chromium Authors. All rights reserved.
no (c)

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/test/function_platform_chromeos.json (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/test/function_platform_chromeos.json:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
no (c)

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/test/function_platform_win_linux.json (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/test/function_platform_win_linux.json:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
no (c)

[Shu Chen, 2016-01-14 02:39:09]

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/cpp_bundle_generator_test.py (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/cpp_bundle_generator_test.py:2: # Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2016/01/13 17:54:33, Devlin wrote:
> update

Done.

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/test/function_platform_all.json (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/test/function_platform_all.json:1: // Copyright (c)
2016 The Chromium Authors. All rights reserved.
On 2016/01/13 17:54:33, Devlin wrote:
> no (c)

Done.

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/test/function_platform_chromeos.json (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/test/function_platform_chromeos.json:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
On 2016/01/13 17:54:33, Devlin wrote:
> no (c)

Done.

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
File tools/json_schema_compiler/test/function_platform_win_linux.json (right):

https://codereview.chromium.org/1558413002/diff/60001/tools/json_schema_compi...
tools/json_schema_compiler/test/function_platform_win_linux.json:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
On 2016/01/13 17:54:33, Devlin wrote:
> no (c)

Done.

[Shu Chen, 2016-01-14 02:39:20]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2016-01-14 02:39:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1558413002/#ps80001
(title: "nits.")

[commit-bot: I haz the power, 2016-01-14 02:45:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558413002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558413002/80001

[commit-bot: I haz the power, 2016-01-14 04:50:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 04:50:51]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)

[Shu Chen, 2016-01-14 05:56:28]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2016-01-14 05:57:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558413002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558413002/80001

[commit-bot: I haz the power, 2016-01-14 06:13:29]

Description was changed from

==========
'linux' platform should exclude 'chromeos' in json compiler.

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None
==========

to

==========
'linux' platform should exclude 'chromeos' in json compiler.

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None
==========

[commit-bot: I haz the power, 2016-01-14 06:13:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-14 06:14:25]

Description was changed from

==========
'linux' platform should exclude 'chromeos' in json compiler.

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None
==========

to

==========
'linux' platform should exclude 'chromeos' in json compiler.

IsPlatformSupported() function in extensions/renderer/resources/binding.js
doesn't include 'chromeos' in 'linux' platform.
So, it should do the same to generate correct macros for api registration.

BUG=517773
TEST=None

Committed: https://crrev.com/dccc97f4646d4752eddf5c2a48542c794e313403
Cr-Commit-Position: refs/heads/master@{#369346}
==========

[commit-bot: I haz the power, 2016-01-14 06:14:27]

Patchset 5 (id:??) landed as
https://crrev.com/dccc97f4646d4752eddf5c2a48542c794e313403
Cr-Commit-Position: refs/heads/master@{#369346}