Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1558353003: Add a count of type parameters to UnlinkedPublicName. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/public_namespace_computer.dart
diff --git a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
index bd9e3a27f00eaacf84100e69e523952cd92dc3a3..21159f07612681103f8b58ab5f8f37b64f3e7817 100644
--- a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
+++ b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
@@ -47,9 +47,11 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
_PublicNamespaceVisitor(this.ctx);
- void addNameIfPublic(String name, PrelinkedReferenceKind kind) {
+ void addNameIfPublic(
+ String name, PrelinkedReferenceKind kind, int numTypeParameters) {
if (isPublic(name)) {
- names.add(encodeUnlinkedPublicName(ctx, name: name, kind: kind));
+ names.add(encodeUnlinkedPublicName(ctx,
+ name: name, kind: kind, numTypeParameters: numTypeParameters));
}
}
@@ -57,17 +59,19 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
@override
visitClassDeclaration(ClassDeclaration node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum);
+ addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum,
+ node.typeParameters?.typeParameters?.length ?? 0);
}
@override
visitClassTypeAlias(ClassTypeAlias node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum);
+ addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum,
+ node.typeParameters?.typeParameters?.length ?? 0);
}
@override
visitEnumDeclaration(EnumDeclaration node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum);
+ addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum, 0);
}
@override
@@ -85,12 +89,14 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
if (node.isSetter) {
name += '=';
}
- addNameIfPublic(name, PrelinkedReferenceKind.other);
+ addNameIfPublic(name, PrelinkedReferenceKind.other,
+ node.functionExpression.typeParameters?.typeParameters?.length ?? 0);
}
@override
visitFunctionTypeAlias(FunctionTypeAlias node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.typedef);
+ addNameIfPublic(node.name.name, PrelinkedReferenceKind.typedef,
+ node.typeParameters?.typeParameters?.length ?? 0);
}
@override
@@ -101,9 +107,9 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
@override
visitVariableDeclaration(VariableDeclaration node) {
String name = node.name.name;
- addNameIfPublic(name, PrelinkedReferenceKind.other);
+ addNameIfPublic(name, PrelinkedReferenceKind.other, 0);
if (!node.isFinal && !node.isConst) {
- addNameIfPublic('$name=', PrelinkedReferenceKind.other);
+ addNameIfPublic('$name=', PrelinkedReferenceKind.other, 0);
}
}
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/format.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698