Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1558353003: Add a count of type parameters to UnlinkedPublicName. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a count of type parameters to UnlinkedPublicName. This will be necessary to allow summaries to be relinked. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9d5e7bf83d98214f3dfd25adf11f3bad1cb36b37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 4 chunks +24 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 4 chunks +15 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +12 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 10 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-06 15:26:23 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-06 16:22:07 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-06 19:34:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d5e7bf83d98214f3dfd25adf11f3bad1cb36b37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698