cpsir: add support for deferred code

cpsir: add support for deferred code

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/e2623f1aea8e7808fc185ce3fcd92d0c3e6f616b

[Siggi Cherem (dart-lang), 2016-01-06 01:34:25]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-01-06 01:42:21]

sigmund@google.com changed reviewers:
+ asgerf@google.com

[Siggi Cherem (dart-lang), 2016-01-06 01:42:22]

Quick question before you review in too much detail: I am not sure what is your
convention for where some of the logic should be - in the irBuilder or the
irBuilderTask? I ended up adding a change on each, but I'm inclined to move the
code I put in irBuilder into the builder task class instead (that means changing
when I call irBuilder.buildStatucGetterGet to call a helper method first,
though).

Cheers,
Siggi

https://codereview.chromium.org/1558353002/diff/20001/tests/language/language...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/1558353002/diff/20001/tests/language/language...
tests/language/language_dart2js.status:273: deferred_super_dependency_test/01:
Crash # Class 'PartialMethodElement' has no instance getter 'initializer'.
this is now failing because of a different issue, similar to the
super_getter_setter_test below.

[Siggi Cherem (dart-lang), 2016-01-06 02:22:03]

Patchset #2 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2016-01-06 02:23:34]

PTAL - I added patchset #2 that keeps it consistent with all the code in the
task.

[asgerf, 2016-01-06 02:34:22]

LGTM with the right evaluation order

https://codereview.chromium.org/1558353002/diff/60001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1558353002/diff/60001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3383: if (prefix != null)
buildCheckDeferredIsLoaded(prefix, send);
I think we need to evaluate the arguments before this check.

Spec p. 70:
"First, the argument list (a1, . . . , an, xn+1 : an+1, . . . , xn+k : an+k) is
evaluated.
If T is a deferred type with prefix p, then if p has not been successfully
loaded, a dynamic error occurs."

[Siggi Cherem (dart-lang), 2016-01-06 03:08:00]

https://codereview.chromium.org/1558353002/diff/60001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1558353002/diff/60001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:3383: if (prefix != null)
buildCheckDeferredIsLoaded(prefix, send);
On 2016/01/06 02:34:21, asgerf wrote:
> I think we need to evaluate the arguments before this check.
> 
> Spec p. 70:
> "First, the argument list (a1, . . . , an, xn+1 : an+1, . . . , xn+k : an+k)
is
> evaluated.
> If T is a deferred type with prefix p, then if p has not been successfully
> loaded, a dynamic error occurs."

Interesting - that's how I thought it should be and how I had it initially, but
I changed it because this test is checking the opposite:

https://github.com/dart-lang/sdk/blob/master/tests/language/deferred_not_load...

If you don't mind, I'm thinking of keeping the semantics to match what we do in
SSA and in the vm for now and separately fix this issue. In particular, I think
the fix in the case of `new` calls is simple, but to fix static calls we'll need
to do some changes in the semantic visitor (for previsitDeferredAccess) that I
rather do separately.

I just filed https://github.com/dart-lang/sdk/issues/25355 with more details.

[asgerf, 2016-01-06 03:14:49]

Ok, LGTM

[Siggi Cherem (dart-lang), 2016-01-06 18:24:55]

Description was changed from

==========
cpsir: add support for deferred code
==========

to

==========
cpsir: add support for deferred code

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e2623f1aea8e7808fc185ce3fcd92d0c3e6f616b
==========

[Siggi Cherem (dart-lang), 2016-01-06 18:24:56]

Committed patchset #2 (id:60001) manually as
e2623f1aea8e7808fc185ce3fcd92d0c3e6f616b (presubmit successful).