Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1558273002: Revert of Don't use Compositor::Initialize for Aura Android (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, mfomitchev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't use Compositor::Initialize for Aura Android (patchset #2 id:20001 of https://codereview.chromium.org/1481623002/ ) Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Original issue's description: > Don't use Compositor::Initialize for Aura Android > > The static function is implemented in compositor_impl_android.cc. But Aura > Android wont compile the file. > > BUG=561669 > > Committed: https://crrev.com/fda1e7f4c4bb69a52d1be0c18366f53b89f81ce0 > Cr-Commit-Position: refs/heads/master@{#362708} TBR=sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=561669 Committed: https://crrev.com/bf61917e9a71121634c8d0f0fe0a8d1a5776d75f Cr-Commit-Position: refs/heads/master@{#367607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/chrome_browser_main_android.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bshe
Created Revert of Don't use Compositor::Initialize for Aura Android
4 years, 11 months ago (2016-01-05 19:15:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558273002/1
4 years, 11 months ago (2016-01-05 19:17:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 19:22:07 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 19:22:59 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf61917e9a71121634c8d0f0fe0a8d1a5776d75f
Cr-Commit-Position: refs/heads/master@{#367607}

Powered by Google App Engine
This is Rietveld 408576698