Chromium Code Reviews

Issue 1558263002: Revert of Exclude some extension apis for Aura Android (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
Reviewers:
Finnur, mfomitchev
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Hadi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Exclude some extension apis for Aura Android (patchset #3 id:40001 of https://codereview.chromium.org/1482643002/ ) Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Original issue's description: > Exclude some extension apis for Aura Android > > Extension is not supported for Aura Android yet. So exclude some of them > to avoid pull unnecessary dependancy. > > BUG=548797 > > Committed: https://crrev.com/72e623ac3ef6cdc9d2323361eebe6f6a320a4b93 > Cr-Commit-Position: refs/heads/master@{#362978} TBR=finnur@chromium.org,mfomitchev@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548797 Committed: https://crrev.com/b0f604120840de50973da0b692f96cff0b7b3823 Cr-Commit-Position: refs/heads/master@{#367602}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+21 lines, -54 lines)
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 4 chunks +2 lines, -9 lines 0 comments
M chrome/chrome_browser_extensions.gypi View 4 chunks +16 lines, -23 lines 0 comments
M chrome/common/extensions/api/schemas.gni View 1 chunk +0 lines, -3 lines 0 comments
M chrome/common/extensions/api/schemas.gypi View 4 chunks +3 lines, -12 lines 0 comments

Messages

Total messages: 5 (1 generated)
bshe
Created Revert of Exclude some extension apis for Aura Android
4 years, 11 months ago (2016-01-05 19:12:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558263002/1
4 years, 11 months ago (2016-01-05 19:12:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 19:15:07 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 19:16:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0f604120840de50973da0b692f96cff0b7b3823
Cr-Commit-Position: refs/heads/master@{#367602}

Powered by Google App Engine