Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2116)

Unified Diff: ui/message_center/message_center.h

Issue 15582004: Move NotificationDelegate into message_center. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some more cosmetic fixes. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/fake_message_center.cc ('k') | ui/message_center/message_center.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/message_center.h
diff --git a/ui/message_center/message_center.h b/ui/message_center/message_center.h
index d971a30b52e5b747ca439532d71890b81ed7deb7..d1142698f9b19b59f633fedaef8374a66af3ebe7 100644
--- a/ui/message_center/message_center.h
+++ b/ui/message_center/message_center.h
@@ -91,14 +91,14 @@ class MESSAGE_CENTER_EXPORT MessageCenter {
// from the extension. Otherwise if |display_source| is provided, a menu item
// showing the source and allowing notifications from that source to be
// disabled will be shown. All actual disabling is handled by the Delegate.
- virtual void AddNotification(
- NotificationType type,
- const std::string& id,
- const string16& title,
- const string16& message,
- const string16& display_source,
- const std::string& extension_id,
- const base::DictionaryValue* optional_fields) = 0;
+ virtual void AddNotification(NotificationType type,
Jun Mukai 2013/05/22 23:08:30 Can we just receive message_center::Notification*
dewittj 2013/05/24 01:03:51 I was imagining that moving to pointers to Notific
+ const std::string& id,
+ const string16& title,
+ const string16& message,
+ const string16& display_source,
+ const std::string& extension_id,
+ const base::DictionaryValue* optional_fields,
+ NotificationDelegate* delegate) = 0;
// Updates an existing notification with id = old_id and set its id to new_id.
// |optional_fields| can be NULL in case of no updates on those fields.
« no previous file with comments | « ui/message_center/fake_message_center.cc ('k') | ui/message_center/message_center.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698