Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: ui/message_center/cocoa/popup_collection_unittest.mm

Issue 15582004: Move NotificationDelegate into message_center. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some more cosmetic fixes. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/cocoa/popup_collection_unittest.mm
diff --git a/ui/message_center/cocoa/popup_collection_unittest.mm b/ui/message_center/cocoa/popup_collection_unittest.mm
index 73c8a63862da23b290e5f96f045f1c3c6a5531f6..a21fb5f1c276e3184846fbc986978e5a35eaafb5 100644
--- a/ui/message_center/cocoa/popup_collection_unittest.mm
+++ b/ui/message_center/cocoa/popup_collection_unittest.mm
@@ -47,6 +47,7 @@ class PopupCollectionTest : public ui::CocoaTest {
" be displayed"),
string16(),
std::string(),
+ NULL,
NULL);
center_->AddNotification(message_center::NOTIFICATION_TYPE_SIMPLE,
"2",
@@ -54,6 +55,7 @@ class PopupCollectionTest : public ui::CocoaTest {
ASCIIToUTF16("This is the second notification."),
string16(),
std::string(),
+ NULL,
NULL);
center_->AddNotification(message_center::NOTIFICATION_TYPE_SIMPLE,
"3",
@@ -65,6 +67,7 @@ class PopupCollectionTest : public ui::CocoaTest {
"set the screen size too small."),
string16(),
std::string(),
+ NULL,
NULL);
}
@@ -102,6 +105,7 @@ TEST_F(PopupCollectionTest, AttemptFourOneOffscreen) {
ASCIIToUTF16("This is the fourth notification."),
string16(),
std::string(),
+ NULL,
NULL);
// Remove "1" and "4" should fit on screen.
@@ -144,7 +148,8 @@ TEST_F(PopupCollectionTest, LayoutSpacing) {
ASCIIToUTF16("This is the fourth notification."),
string16(),
std::string(),
- optional.get());
+ optional.get(),
+ NULL);
EXPECT_TRUE(CheckSpacingBetween([popups objectAtIndex:2],
[popups objectAtIndex:3]));
@@ -174,6 +179,7 @@ TEST_F(PopupCollectionTest, TinyScreen) {
" be displayed"),
string16(),
std::string(),
+ NULL,
NULL);
EXPECT_EQ(1u, [[collection_ popups] count]);
@@ -226,6 +232,7 @@ TEST_F(PopupCollectionTest, UpdateIconAndBody) {
"longer body"),
string16(),
std::string(),
+ NULL,
NULL);
EXPECT_GT(NSHeight([[controller view] frame]), NSHeight(old_frame));

Powered by Google App Engine
This is Rietveld 408576698