Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1558143003: Fix Hebrew list-style number ordering (Closed)

Created:
4 years, 11 months ago by rwlbuis
Modified:
4 years, 11 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Hebrew list-style number ordering Hebrew numbers are generally written from largest to smallest, which in RTL Hebrew script, means the largest is right-most. Therefore make toHebrewUnder1000 take a vector and use prepend to make sure largest number ends up right-most. BUG=498678 Committed: https://crrev.com/81463d905d9f7aa0153bae9f703728632ce8b0f6 Cr-Commit-Position: refs/heads/master@{#368990}

Patch Set 1 #

Patch Set 2 : V2 #

Patch Set 3 : V3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/lists/w3-list-styles-expected.txt View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ListMarkerText.cpp View 1 2 chunks +14 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
rwlbuis
PTAL.
4 years, 11 months ago (2016-01-05 15:32:00 UTC) #3
rwlbuis
On 2016/01/05 15:32:00, rwlbuis wrote: > PTAL. ping? :)
4 years, 11 months ago (2016-01-12 18:55:25 UTC) #5
eae
This is great, thank you LGTM
4 years, 11 months ago (2016-01-12 18:59:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558143003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558143003/40001
4 years, 11 months ago (2016-01-12 19:29:13 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-12 21:27:59 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 21:28:48 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/81463d905d9f7aa0153bae9f703728632ce8b0f6
Cr-Commit-Position: refs/heads/master@{#368990}

Powered by Google App Engine
This is Rietveld 408576698