Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 1558133002: Soften assertion slightly, to survive saturated arithmetic situations. (Closed)

Created:
4 years, 11 months ago by mstensho (USE GERRIT)
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Soften assertion slightly, to survive saturated arithmetic situations. We do want to be at the exact top of a column here, but if the flow thread top offset for the next column is larger than what a LayoutUnit can hold, we get a bogus value passed here. Survive the assertion and carry on. BUG=574309 R=leviw@chromium.org Committed: https://crrev.com/59bc118f74edef7b3e4a2f5f2010066893aa27bb Cr-Commit-Position: refs/heads/master@{#370297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
A + third_party/WebKit/LayoutTests/fast/multicol/short-columns-insane-unbreakable-content-height-crash.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/multicol/short-columns-insane-unbreakable-content-height-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
4 years, 11 months ago (2016-01-05 12:52:59 UTC) #1
leviw_travelin_and_unemployed
lgtm lol @ test name.
4 years, 11 months ago (2016-01-20 00:34:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558133002/1
4 years, 11 months ago (2016-01-20 00:38:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 04:09:28 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 04:11:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59bc118f74edef7b3e4a2f5f2010066893aa27bb
Cr-Commit-Position: refs/heads/master@{#370297}

Powered by Google App Engine
This is Rietveld 408576698